Hi Rob,

I noticed this problem with DNN 4.5.1 and I have not yet had time to look at it. I am investigating now and will release a version that will work with DNN4.5.1 shortly.

Ok - version 1.0.2 has now been released for DNN 4.5.x+

Ah yes, I was worried about this - basically this module version is almost 2 years old - a lot has changed since then and I noticed it had the UP .dlls in the .zip file - this would overwrite the latest UP .dlls with the 2 year old ones (the DNN core installer is very stupid and does not realise that they are newer!) So Itook these out, and thought I had removed all the references, and must have tested it on a machine with the UP installed.

For a quick fix, email me on rod * smart-thinker.com and I will send you the 2 .dlls which you can put in your bin - this should temp. fix it until I decide on the best course of action (or just install the UP module (you dont have to use it)).

Hi,

After thinking about this problem, I have decided that it will be easier and safer to not include the .dlls in the .zip file - ie. you will need to have the Smart-Thinker UserProfile module installed (even if you do not use it).

My reasoning was that if someone installed the Quotes module after a newer version of the UserProfile module it would cause the module to cease working, whereas in this scenario the worst case is that the Quotes module will not work immediately after install (and it's easy to fix). I'll pin this to help others know that the solution is to have the UserProfile module installed too.

In the next major version I will fix this so it's not a prob...

Hello David,

1. Are you using the Smart-Thinker UserProfile module on this portal?
2. Are there any error messages in your Event Viewer when you view a quote?
3. Are you using Censorship or have you turned this off?
4. What retrieval method areyou using? (Random, etc.)

Hi,

By Event Viewer I meant the Event Log under Site Settings - It is possible the module is throwing an error and hiding the details from the UI. Sorry, I did not understand - did it work when you set it to Quotes, or has it never shown anything?

Hi David,

Sorry for the late reply - I have been on holiday - can you go to the Settings of the Quotes module and change it from Random to a selected quote? I want to try and get it working with a normal quote and then we can change it to do what you want.

Hi David,

No, I have not had this happen before really - I saw something similar but there was an error in the error log which narrowed it down quickly.

Is there any way you can give me admin rights for a few minutes on your portal? If not, no worries, but if so, please send details to rod at smart-thinker.com. I can see the problem but I need to try a few different configurations to try and work out what is going wrong.

Hi All,

David and I have narrowed down the problem to a missing ObjectQualifier in the GetNextQuote stored proc.

Here is the fix if you encounter this problem - you will need to run the SQL below (replace {databaseOwner}{objectQualifier}). I will release this in a minor update at some point.

if exists (select * from dbo.sysobjects where id = object_id(N'{databaseOwner}{objectQualifier}SmartThinker_QuoteGetQuote_C') and OBJECTPROPERTY(id, N'IsProcedure') = 1)
drop procedure {databaseOwner}{objectQualifier}SmartThinker_QuoteGetQuote_C
GO

SET QUOTED_IDENTIFIER ON
GO
SET ANSI_NULLS ON
GO


CREATE      PROCEDURE {databaseOwner}{objectQualifier}SmartThinker_QuoteGetQuote_C
@QuoteID INT,
@CensorRatingID INT,
@RetrievalType INT,
@CategoryID INT
/*
Author: Rodney Joyce
Date created: 21/09/04
Purpose: Get a specific quote, or a random one if QuoteID = -1 (always within the Censorship though) from any of the users for all portals
Notes: Will check User table for ID and if it doesn't exist will use the Source. Also checks CensorRating is <= the passed in one (Pass in 99999 for all). Also checks ApprovalStatus to get Approved quotes only
Updates: RetrievalType is either 0 (Random) or 1 (Least Asked)
Copyright: Smart-Thinker 2005
*/
AS
IF @QuoteID = -1
BEGIN
    IF @RetrievalType = -1
    BEGIN
        -- Get a Random Quote (must be active)
        DECLARE @num_recs INT
        DECLARE @rand_num INT
        -- Create a temporary table with the primary key of the table to return and identity column to use for the random lookup
        DECLARE @tabTempRandom TABLE(
            RowNum INT IDENTITY(1, 1) PRIMARY KEY CLUSTERED,
            TempQuoteID INT)
       
        -- Fill temp table with primary key
        INSERT INTO @tabTempRandom
        SELECT Q.QuoteID
        FROM {objectQualifier}SmartThinker_Quote Q
        -- must be active and below the censorship level
        WHERE QuoteStatusID = 1
        AND ApprovalStatusID = 1
        AND CensorRatingID <= @CensorRatingID   
        AND (Q.CategoryID = @CategoryID OR @CategoryID = -1)
       
        -- Get the number of records in our temp table
        SET @num_recs = @@ROWCOUNT
       
        -- Select a random number between 1 and the number of records in our table
        SET @rand_num = ROUND(((@num_recs - 1) * RAND() + 1), 0)
       
        -- Select the record from the table, joined with the temp table
        SELECT @QuoteID = [QuoteID]
        FROM {objectQualifier}SmartThinker_Quote Q
        INNER JOIN @tabTempRandom TR ON TR.TempQuoteID = Q.QuoteID
        WHERE Q.QuoteID = TR.TempQuoteID AND TR.RowNum = @Rand_Num
    END
    ELSE
    BEGIN
        --Least Asked
        SELECT TOP 1 @QuoteID = [QuoteID]
        FROM {objectQualifier}SmartThinker_Quote Q
        WHERE QuoteStatusID = 1
        AND ApprovalStatusID = 1
        AND Q.CensorRatingID <= @CensorRatingID       
        AND (Q.CategoryID = @CategoryID OR @CategoryID = -1)
        ORDER BY ViewCounter
    END
END
SELECT       
    [QuoteID],
    Q.[PortalID],   
    [QuoteText],
    [Context],
    [SaidByUserID],
    ISNULL(U.FirstName + ' ' + U.Lastname, Source) AS Source,
    [InventedDate],
    [LastShownDate],
    [ViewCounter],
    [ApprovalStatusID],
    [QuoteStatusID],
    Q.[CensorRatingID],
    [CreatedDate],
    [ChangedDate],
    [CreatedByUserID],
    [ChangedByUserID],
    --custom
    L1.Text AS CensorRatingName,
    [CategoryID]
FROM {objectQualifier}SmartThinker_Quote Q
LEFT JOIN {objectQualifier}Users U ON U.UserID = SaidByUserID
LEFT JOIN {objectQualifier}Lists L1 ON L1.Value = Q.CensorRatingID AND L1.ListName = 'SmartThinker_Censorship'
WHERE Q.QuoteID = @QuoteID
GO
SET QUOTED_IDENTIFIER OFF
GO
SET ANSI_NULLS ON
GO